Table transformer #1900
Open
Table transformer #1900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mht-sharma — if you have a minute to review my PR, I would appreciate it! |
mht-sharma
requested changes
Jun 18, 2024
There was a problem hiding this comment.
@zachmayer thanks for the PR. I suppose having an ORTModelForObjectDetection would be better than using ORTModelForCustomTasks since this is more generic. Could you please add a class for this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add support for the table transformer in the optimizer class: #1761
The table transformer does not support
ORTModelForImageClassificationand there's noORTModelForObjectDetection, so I just used ORTModelForCustomTasks.Maybe a good follow-up task would be to add
ORTModelForObjectDetectionand possibly alsoORTModelForImageFeatureExtraction(asORTModelForFeatureExtractiononly supports text models)I ran this on
microsoft/table-transformer-detectionand confirmed it optimizes the model:Onnx model graph: 2247
Opt model graph: 1136
I see a very small speedup in inference time.
Onnx Model Time: 65.42 reps per second
Optimized Onnx Model Time: 67.34 reps per second
The optimized model binary is slightly smaller than the original model. (115.0mb vs 115.1mb)
Fixes # (issue)
Before submitting
Who can review?